[webkit-reviews] review granted: [Bug 125333] [Cocoa] Add load delegate methods for responding to authentication challenges : [Attachment 218568] THIS IS YOUR CHALLENGE

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 125333: [Cocoa] Add load delegate methods for responding to authentication
challenges
https://bugs.webkit.org/show_bug.cgi?id=125333

Attachment 218568: THIS IS YOUR CHALLENGE
https://bugs.webkit.org/attachment.cgi?id=218568&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218568&action=review


>>> Source/WebKit2/UIProcess/API/Cocoa/WKNSURLAuthenticationChallenge.mm:52
>>> +	 });
>> 
>> I don't understand how this works. I know that this is how we always use
dispatch_once, and that man dispatch_once has this pattern as example, but I
still don't understand how a regular static dispatch_once_t token can be used
here without thread safe statics.
>> 
>> And if we had thread safe statics, we'd just use 
>> 
>> static WKNSURLAuthenticationChallengeSender *sender =
[[WKNSURLAuthenticationChallengeSender alloc] init];
> 
> I am not sure what part is not understood. The compiler option we use is
documented as follows:
>     -fno-threadsafe-statics	 Do not emit code to make initialization of
local statics thread safe
> which has nothing to do with the value of uninitialized local statics.

To me this looks correct.