[webkit-reviews] review granted: [Bug 117729] [ATK] Missing aria roles mappings. : [Attachment 216658] Patch set #10

Fri Dec 6 05:29:31 PST 2013

Mario Sanchez Prada <mario at webkit.org> has granted Lukasz Gajowy
<l.gajowy at samsung.com>'s request for review:
Bug 117729: [ATK] Missing aria roles mappings.
https://bugs.webkit.org/show_bug.cgi?id=117729

Attachment 216658: Patch set #10
https://bugs.webkit.org/attachment.cgi?id=216658&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #40)
> [...]
> > The patch looks good to me now, but I'd like you to reconsider Chris's
suggestion (see my previous comment) here too, if possible
> 
> I cannot apply to Chris suggestion, because it doesn't work like this on efl
port (probably a bug). When i: 
> 1) provide id="body" to <body>
> 2) invoke var body = accessibilityControler.getAccessibleElementById("body")
> 3) debug(body.role)
> I get the error "null is not an object". 
> 
> This is why i decided to do this the other way.

Ok

(In reply to comment #41)
> On below link there is a bug report regarding to the
accessibilityControler.getAccessibleElementById("body") problem:
> 
> https://bugs.webkit.org/show_bug.cgi?id=125343

Nice. Now I do not see any reason why we should not give this a try.

Thanks!