[webkit-reviews] review requested: [Bug 125341] Remove function from style/checkers/cpp.py : [Attachment 218579] patch removes a function

[bugzilla-daemon at webkit.org]

Tamas Gergely <tgergely.u-szeged at partner.samsung.com> has asked  for review:
Bug 125341: Remove function from style/checkers/cpp.py
https://bugs.webkit.org/show_bug.cgi?id=125341

Attachment 218579: patch removes a function
https://bugs.webkit.org/attachment.cgi?id=218579&action=review

------- Additional Comments from Tamas Gergely
<tgergely.u-szeged at partner.samsung.com>
I have simply split the functionality of process_file_data into two parts: the
checker is now created directly in the CppStyleTestBase unit test, while
setting the module's global _unit_test_config is done from the constructor of
CppChecker.
Although currently it causes no problem, I think that setting the global from
the constructor is not a nice nor safe solution. What could be done are:
- move the global into the CppChecker class and propagate its value (through 3
functions) to the only place it is used (the 3 functions are used nowhere
else), or
- move all the functions (or almost all) into the CppChecker class, or
- leave it as it is now.
By the way, to set up some specific environments, the cpp_unittest uses both
globals and parameter propagation. Is one of them preferred?