[webkit-reviews] review granted: [Bug 125328] JSC: Simplify interface between throw and catch handler : [Attachment 218562] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 5 20:26:22 PST 2013
Geoffrey Garen <ggaren at apple.com> has granted Michael Saboff
<msaboff at apple.com>'s request for review:
Bug 125328: JSC: Simplify interface between throw and catch handler
https://bugs.webkit.org/show_bug.cgi?id=125328
Attachment 218562: Patch
https://bugs.webkit.org/attachment.cgi?id=218562&action=review
------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218562&action=review
r=me
> Source/JavaScriptCore/jit/CCallHelpers.h:1578
> move(TrustedImmPtr(vm()), GPRInfo::regT0);
> loadPtr(Address(GPRInfo::regT0,
VM::targetMachinePCForThrowOffset()), GPRInfo::regT1);
This should just be a load of an absolute address
(VM::targetMachinePCForThrow). No need to put VM in a register.
More information about the webkit-reviews
mailing list