[webkit-reviews] review granted: [Bug 125298] 32bit buildfix after r160151 : [Attachment 218503] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonác <ossy at webkit.org> has granted  review:
Bug 125298: 32bit buildfix after r160151
https://bugs.webkit.org/show_bug.cgi?id=125298

Attachment 218503: Patch
https://bugs.webkit.org/attachment.cgi?id=218503&action=review

------- Additional Comments from Csaba Osztrogonác <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218503&action=review


>> Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:943
>> +	GST_LOG_OBJECT(src, "Have %lld bytes of data", priv->buffer ?
static_cast<long long>(gst_buffer_get_size(priv->buffer.get())) : length);
> 
> Perhaps use %zd ?

gst_buffer_get_size returns unsigned int (32bit), length is int (32bit).
An unsigned int can be extended properly to long long int (64bit) on x86.
So it is the proper fix, r=me to fix the build as soon as possible.