[webkit-reviews] review granted: [Bug 125304] [GStreamer] Audio/Video sink management is incoherent : [Attachment 218521] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Dec 5 10:52:37 PST 2013
Gustavo Noronha (kov) <gns at gnome.org> has granted Philippe Normand
<pnormand at igalia.com>'s request for review:
Bug 125304: [GStreamer] Audio/Video sink management is incoherent
https://bugs.webkit.org/show_bug.cgi?id=125304
Attachment 218521: patch
https://bugs.webkit.org/attachment.cgi?id=218521&action=review
------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218521&action=review
>
Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
505
> +GstElement* MediaPlayerPrivateGStreamerBase::videoSink() const
> +{
> + return m_fpsSink ? m_fpsSink.get() : m_webkitVideoSink.get();
> +}
This looks unused, will be used in a follow-up patch I guess?
More information about the webkit-reviews
mailing list