[webkit-reviews] review denied: [Bug 125305] Incorrect usage of ThreadingOnce class. : [Attachment 218513] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Dec 5 10:25:42 PST 2013


Geoffrey Garen <ggaren at apple.com> has denied peavo at outlook.com's request for
review:
Bug 125305: Incorrect usage of ThreadingOnce class.
https://bugs.webkit.org/show_bug.cgi?id=125305

Attachment 218513: Patch
https://bugs.webkit.org/attachment.cgi?id=218513&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218513&action=review


> Source/JavaScriptCore/ChangeLog:9
> +	   On Mac, the class cannot be used as a global static, as global
constructors/destructors fails to compile with the current compiler settings.

Those compiler settings exist for a reason. We want other platforms to get
closer to being able to enable those settings, not farther away.


More information about the webkit-reviews mailing list