[webkit-reviews] review granted: [Bug 125272] [Win] Exiting from Media Full Screen mode via 'escape' key does not work properly : [Attachment 218520] Patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 125272: [Win] Exiting from Media Full Screen mode via 'escape' key does not
work properly
https://bugs.webkit.org/show_bug.cgi?id=125272

Attachment 218520: Patch
https://bugs.webkit.org/attachment.cgi?id=218520&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218520&action=review


r=me, with nit.

> Source/WebKit/win/WebView.cpp:6958
> -   
m_fullScreenElement->document().webkitWillExitFullScreenForElement(m_fullScreen
Element.get());
> +    m_fullScreenElement->document().webkitExitFullscreen();

This should probably use webkitCancelFullScreen(), which will pop the entire
full screen element stack.