[webkit-reviews] review granted: [Bug 125266] [Cocoa] Make WKConnection work with WKObject wrapping : [Attachment 218471] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 17:03:48 PST 2013


mitz at webkit.org <mitz at webkit.org> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 125266: [Cocoa] Make WKConnection work with WKObject wrapping
https://bugs.webkit.org/show_bug.cgi?id=125266

Attachment 218471: Patch
https://bugs.webkit.org/attachment.cgi?id=218471&action=review

------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218471&action=review


> Source/WebKit2/UIProcess/API/Cocoa/WKConnection.mm:111
> +	   _remoteObjectRegistry = adoptNS([[WKRemoteObjectRegistry alloc]
_initWithConnectionRef:toAPI(_connection.get())]);

We should change the internal WKRemoteObjectRegistry initializer to take a
WebConnection&.


More information about the webkit-reviews mailing list