[webkit-reviews] review granted: [Bug 125263] Bad repaints on Twitter when the tile cache has a margin : [Attachment 218468] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 125263: Bad repaints on Twitter when the tile cache has a margin
https://bugs.webkit.org/show_bug.cgi?id=125263

Attachment 218468: Patch
https://bugs.webkit.org/attachment.cgi?id=218468&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218468&action=review


> Source/WebCore/platform/graphics/ca/mac/TileController.mm:755
> +	   // If there are magin tiles and the bounds have grown taller or
wider, then the tiles that used to

margin

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:761
> +		   IntRect boundsWithoutMargin = IntRect(IntPoint(),
expandedIntSize(m_tileCacheLayer->bounds().size()));
> +		   IntRect oldBoundsWithoutMargin = IntRect(IntPoint(),
m_boundsAtLastRevalidate.size());
> +		   oldBoundsWithoutMargin.contract(IntSize(leftMarginWidth() +
rightMarginWidth(), topMarginHeight() + bottomMarginHeight()));

it might be nice if these things were factored out, especially the things that
are done elsewhere

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:763
> +		   if (bounds.height() > m_boundsAtLastRevalidate.height()) {

smfr mentioned when things get shorter/skinnier, and you said that it didn't
seem to be an issue, but I wonder why? what is invalidating the layer in that
case? why doesn't it have stale content? would be nice to have a clear
understanding.