[webkit-reviews] review granted: [Bug 125259] Make the estimatedProgress property observable using KVO : [Attachment 218461] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Wed Dec 4 15:36:25 PST 2013
mitz at webkit.org <mitz at webkit.org> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 125259: Make the estimatedProgress property observable using KVO
https://bugs.webkit.org/show_bug.cgi?id=125259
Attachment 218461: Patch
https://bugs.webkit.org/attachment.cgi?id=218461&action=review
------- Additional Comments from mitz at webkit.org <mitz at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218461&action=review
> Source/WebKit2/UIProcess/PageLoadState.cpp:73
> + m_estimatedProgress = 0.0;
No need for “.0”. Should we be doing this if the value is already 0?
> Source/WebKit2/UIProcess/PageLoadState.cpp:234
> + m_estimatedProgress = 1.0;
No need for “.0” here.
More information about the webkit-reviews
mailing list