[webkit-reviews] review granted: [Bug 124461] Refactor static getter function prototype to include thisValue in addition to the base object : [Attachment 218451] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 15:10:06 PST 2013


Geoffrey Garen <ggaren at apple.com> has granted Oliver Hunt <oliver at apple.com>'s
request for review:
Bug 124461: Refactor static getter function prototype to include thisValue in
addition to the base object
https://bugs.webkit.org/show_bug.cgi?id=124461

Attachment 218451: Patch
https://bugs.webkit.org/attachment.cgi?id=218451&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218451&action=review


r=me

> Source/JavaScriptCore/ChangeLog:14
> +	   that this patch does not result in any change in behaviour

Period, please.

You should also mention the future changes you're planning: moving DOM
properties to prototypes.


More information about the webkit-reviews mailing list