[webkit-reviews] review denied: [Bug 124708] DataCloneError exception is not thrown after invalid postMessage method invocation : [Attachment 217782] Proposed Path 2

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Michał Poteralski
<m.poteralski at samsung.com>'s request for review:
Bug 124708: DataCloneError exception is not thrown after invalid postMessage
method invocation
https://bugs.webkit.org/show_bug.cgi?id=124708

Attachment 217782: Proposed Path 2
https://bugs.webkit.org/attachment.cgi?id=217782&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=217782&action=review


Seems fine to make this change.

>
LayoutTests/http/tests/security/postMessage/postMessage-clone-port-error.html:3

> +<script src="../../../../resources/js-test-pre.js"></script>

In HTTP tests, you don't need to use relative paths, can be just
"/resources/js-test-pre.js".

But then I'm not sure why this is an HTTP test. Can it be a regular one? It's
better to make non-HTTP tests when possible, because HTTP tests are slower.

>
LayoutTests/http/tests/security/postMessage/postMessage-clone-port-error.html:2
3
> +</html>

You should also include js-test-post.js - it signals that a test has been run
in full.