[webkit-reviews] review granted: [Bug 125246] check-webkit-style detected some turnary statements as initialization lists : [Attachment 218432] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 125246: check-webkit-style detected some turnary statements as
initialization lists
https://bugs.webkit.org/show_bug.cgi?id=125246

Attachment 218432: Patch
https://bugs.webkit.org/attachment.cgi?id=218432&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218432&action=review


> Tools/Scripts/webkitpy/style/checkers/cpp.py:1989
> +    if search(r'^(?P<indentation>\s*)((explicit
)?[^\s]+\(.*\)\s?\:|^\s*\:).*[^;]*$', line):

Should this be explicit\s+ ?

> Tools/Scripts/webkitpy/style/checkers/cpp_unittest.py:4986
> +	   self.assert_lint('o = foo(b ? bar() : baz());', '')

Should you have a test with "explicit" too?