[webkit-reviews] review granted: [Bug 125242] Replace USE(SECURITY_FRAMEWORK) with finer-grained defines : [Attachment 218428] Remove USE(SECURITY_FRAMEWORK) and add HAVE(SEC_IDENTITY), HAVE(SEC_KEYCHAIN), and ENABLE(SEC_ITEM_SHIM)

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted mitz at webkit.org <mitz at webkit.org>'s
request for review:
Bug 125242: Replace USE(SECURITY_FRAMEWORK) with finer-grained defines
https://bugs.webkit.org/show_bug.cgi?id=125242

Attachment 218428: Remove USE(SECURITY_FRAMEWORK) and add HAVE(SEC_IDENTITY),
HAVE(SEC_KEYCHAIN), and ENABLE(SEC_ITEM_SHIM)
https://bugs.webkit.org/attachment.cgi?id=218428&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218428&action=review


> Source/WebKit2/config.h:102
> +#ifndef HAVE_SEC_IDENTITY
> +#if PLATFORM(MAC) && !PLATFORM(IOS)
> +#define HAVE_SEC_IDENTITY 1
> +#endif
> +#endif
> +
> +#ifndef HAVE_SEC_KEYCHAIN
> +#if PLATFORM(MAC) && !PLATFORM(IOS)
> +#define HAVE_SEC_KEYCHAIN 1
> +#endif
> +#endif

I would move these to Platform.h, as they could apply to any of the projects. 
The Shim is WebKit2 specific, so can stay here.