[webkit-reviews] review denied: [Bug 125231] [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting API clients : [Attachment 218426] Rebased patch

[bugzilla-daemon at webkit.org]

Martin Robinson <mrobinson at webkit.org> has denied Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 125231: [EFL][GTK][WK2] Remove unnecessary reinterpret_casts when setting
API clients
https://bugs.webkit.org/show_bug.cgi?id=125231

Attachment 218426: Rebased patch
https://bugs.webkit.org/attachment.cgi?id=218426&action=review

------- Additional Comments from Martin Robinson <mrobinson at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218426&action=review


Looks good apart from the ChangeLog weirdness.

> Source/WebKit2/ChangeLog:72
> +	   * UIProcess/API/gtk/WebKitFullscreenClient.cpp:
> +	   (attachFullScreenClientToView):
> +	   * UIProcess/API/gtk/WebKitRequestManagerClient.cpp:
> +	   (attachRequestManagerClientToContext):
> +	   * UIProcess/API/gtk/WebKitTextChecker.cpp:
> +	   (WebKitTextChecker::WebKitTextChecker):
> +	   * UIProcess/API/gtk/WebKitWebInspector.cpp:
> +	   (webkitWebInspectorCreate):
> +	   * UIProcess/efl/BatteryProvider.cpp:
> +	   (BatteryProvider::BatteryProvider):
> +	   * UIProcess/efl/NetworkInfoProvider.cpp:
> +	   (NetworkInfoProvider::NetworkInfoProvider):
> +	   * UIProcess/efl/RequestManagerClientEfl.cpp:
> +	   (WebKit::RequestManagerClientEfl::RequestManagerClientEfl):
> +	   * UIProcess/efl/TextCheckerClientEfl.cpp:
> +	   (TextCheckerClientEfl::TextCheckerClientEfl):
> +	   * UIProcess/efl/VibrationClientEfl.cpp:
> +	   (VibrationClientEfl::VibrationClientEfl):
> +	   * UIProcess/efl/ViewClientEfl.cpp:

It seems wrong to update an old ChangeLog entry.