[webkit-reviews] review denied: [Bug 125216] Do not emit #if-#endif guards for caluclation the number of StructOffset and Sizeof nodes. : [Attachment 218395] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Dec 4 09:09:30 PST 2013


Filip Pizlo <fpizlo at apple.com> has denied László Langó
<lango at inf.u-szeged.hu>'s request for review:
Bug 125216: Do not emit #if-#endif guards for caluclation the number of
StructOffset and Sizeof nodes.
https://bugs.webkit.org/show_bug.cgi?id=125216

Attachment 218395: Patch
https://bugs.webkit.org/attachment.cgi?id=218395&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
Why do you think this is right?  Note that this code is for MachO fat binary
support so please test a fat binary build on Mac.


More information about the webkit-reviews mailing list