[webkit-reviews] review denied: [Bug 124325] Consolidate and expose Frame/Node/Selection screenshot capabilities : [Attachment 217917] v4 - an actual patch, not the url

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 16:19:47 PST 2013


Simon Fraser (smfr) <simon.fraser at apple.com> has denied Brian Burg
<burg at cs.washington.edu>'s request for review:
Bug 124325: Consolidate and expose Frame/Node/Selection screenshot capabilities
https://bugs.webkit.org/show_bug.cgi?id=124325

Attachment 217917: v4 - an actual patch, not the url
https://bugs.webkit.org/attachment.cgi?id=217917&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217917&action=review


> Source/WebCore/bindings/objc/DOM.mm:338
> +    return [createDragImageForRange(*frame, *range,
forceBlackText).leakRef() autorelease];

createDragImageForRange is the wrong name for that function; it's nothing to do
with dragging at many call sites.


More information about the webkit-reviews mailing list