[webkit-reviews] review denied: [Bug 124626] Allow ImageBuffer to use a backing store that is larger than necessary : [Attachment 218260] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied Myles C. Maxfield
<mmaxfield at apple.com>'s request for review:
Bug 124626: Allow ImageBuffer to use a backing store that is larger than
necessary
https://bugs.webkit.org/show_bug.cgi?id=124626

Attachment 218260: Patch
https://bugs.webkit.org/attachment.cgi?id=218260&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218260&action=review


> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:210
> +	   image = CGBitmapContextCreateImage(context.get());

Please don't assign to parameters. I think this may also be leaking; you want
adoptCF.