[webkit-reviews] review denied: [Bug 118516] % unit heights don't work if parent block height is set in vh : [Attachment 216911] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has denied gur.trio at gmail.com's
request for review:
Bug 118516: % unit heights don't work if parent block height is set in vh
https://bugs.webkit.org/show_bug.cgi?id=118516

Attachment 216911: Patch
https://bugs.webkit.org/attachment.cgi?id=216911&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=216911&action=review


> Source/WebCore/rendering/RenderBox.cpp:2729
> +    } else if (cbstyle.logicalHeight().isViewportPercentage()) {

Ugh, we should rename the cbstyle variable.

> LayoutTests/ChangeLog:13
> +	   * fast/css/viewport-percentage-compute-box-height-expected.txt:
Added.
> +	   * fast/css/viewport-percentage-compute-box-height.html: Added.
> +	   * fast/css/viewport-percentage-compute-box-width-expected.txt:
Added.
> +	   * fast/css/viewport-percentage-compute-box-width.html: Added.

I would prefer these to be ref tests.