[webkit-reviews] review granted: [Bug 125179] [Win] Support 64-bit Application Support Libraries Location : [Attachment 218333] Patch

[bugzilla-daemon at webkit.org]

Tim Horton <thorton at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 125179: [Win] Support 64-bit Application Support Libraries Location
https://bugs.webkit.org/show_bug.cgi?id=125179

Attachment 218333: Patch
https://bugs.webkit.org/attachment.cgi?id=218333&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218333&action=review


> Tools/ChangeLog:10
> +	   to speficy these locations.

specify

> Tools/Scripts/webkitdirs.pm:1577
> +    # FIXME: Remove the following in https://webkit.org/b/125180

maybe these should say "FIXME (125180): Remove this temporary workaround" or
something. Not sure the style.

> Tools/Scripts/webkitdirs.pm:1614
> +    print "WEBKIT_64_SUPPORT is set to: ", $ENV{"WEBKIT_64_SUPPORT"}, "\n"
if isWin64(); #FIXME: Remove in https://webkit.org/b/125180

space after #

> Tools/Scripts/webkitdirs.pm:2128
> +	   return $ENV{"WEBKIT_64_SUPPORT"}, "\n" if isWin64(); #FIXME: Remove
in https://webkit.org/b/125180

space after #