[webkit-reviews] review granted: [Bug 124483] Support exporting private WebCrypto RSA keys : [Attachment 218322] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Dec 3 12:15:04 PST 2013


Anders Carlsson <andersca at apple.com> has granted Alexey Proskuryakov
<ap at webkit.org>'s request for review:
Bug 124483: Support exporting private WebCrypto RSA keys
https://bugs.webkit.org/show_bug.cgi?id=124483

Attachment 218322: proposed patch
https://bugs.webkit.org/attachment.cgi?id=218322&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218322&action=review


> Source/WebCore/crypto/CommonCryptoUtilities.cpp:82
> +    RELEASE_ASSERT(!status);

I’d rather assert status == kCCSuccess here (and all the other places).


More information about the webkit-reviews mailing list