[webkit-reviews] review denied: [Bug 125168] [MIPS] Wrong register usage in LLInt op_catch. : [Attachment 218311] proposed patch.

[bugzilla-daemon at webkit.org]

Filip Pizlo <fpizlo at apple.com> has denied Balazs Kilvady
<kilvadyb at homejinni.com>'s request for review:
Bug 125168: [MIPS] Wrong register usage in LLInt op_catch.
https://bugs.webkit.org/show_bug.cgi?id=125168

Attachment 218311: proposed patch.
https://bugs.webkit.org/attachment.cgi?id=218311&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218311&action=review


> Source/JavaScriptCore/offlineasm/mips.rb:-535
> -	       if /_prologue$/.match(node.name) ||
/^_llint_function_/.match(node.name)
> +	       if /_prologue$/.match(node.name) ||
/^_llint_function_/.match(node.name) || /_llint_op_catch/.match(node.name)
>		   # Functions called from trampoline/JIT codes.
>		   myList << Instruction.new(node.codeOrigin, "pichdr", [])
> -	       elsif /_llint_op_catch/.match(node.name)
> -		   # Exception cactcher entry point function.
> -		   myList << Instruction.new(node.codeOrigin, "pichdrra", [])

This is atrocious.  Are you seriously matching label names?