[webkit-reviews] review denied: [Bug 124440] Add the CFNetwork implementation of the asynchronous ResourceHandle : [Attachment 218259] Patch

[bugzilla-daemon at webkit.org]

Brent Fulgham <bfulgham at webkit.org> has denied	review:
Bug 124440: Add the CFNetwork implementation of the asynchronous ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=124440

Attachment 218259: Patch
https://bugs.webkit.org/attachment.cgi?id=218259&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218259&action=review


r- because we cannot use block syntax in the Windows code. :-(

> Source/WebCore/platform/network/cf/ResourceHandleCFNet.cpp:205
> +    dispatch_async(dispatch_get_main_queue(), ^{

Unfortunately, this won't work on Windows.  MSVC doesn't support the block
syntax, and I'm not aware of a tool we can use to convert it to something we
can compile cleanly (at least, not using the Open Source toolset).