[webkit-reviews] review granted: [Bug 125146] ASSERTION FAILED: !value || (value->isPrimitiveValue()) in WebCore::StyleProperties::getLayeredShorthandValue. : [Attachment 218291] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted László Langó
<lango at inf.u-szeged.hu>'s request for review:
Bug 125146: ASSERTION FAILED: !value || (value->isPrimitiveValue()) in
WebCore::StyleProperties::getLayeredShorthandValue.
https://bugs.webkit.org/show_bug.cgi?id=125146

Attachment 218291: Patch
https://bugs.webkit.org/attachment.cgi?id=218291&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218291&action=review


> LayoutTests/fast/css/webkit-mask-crash-implicit-expected.txt:3
> +FAIL document.styleSheets[1].rules[0].style.cssText should be
-webkit-mask-repeat: repeat-x; -webkit-mask-repeat-y: inherit;. Was
-webkit-mask: inherit;.
> +FAIL document.styleSheets[1].rules[0].style.getPropertyValue('-webkit-mask')
should be . Was inherit.
> +FAIL
document.styleSheets[1].rules[0].style.getPropertyValue('-webkit-mask-repeat')
should be repeat inherit. Was inherit.

Why is FAIL, FAIL, FAIL expected? Is this another bug? Why not expect the
values we actually expect?