[webkit-reviews] review denied: [Bug 124533] Ability to iterate over API::Array : [Attachment 218200] split out IteratorPair

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Martin Hock <mhock at apple.com>'s request
for review:
Bug 124533: Ability to iterate over API::Array
https://bugs.webkit.org/show_bug.cgi?id=124533

Attachment 218200: split out IteratorPair
https://bugs.webkit.org/attachment.cgi?id=218200&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218200&action=review


One more pass!

> Source/WebKit2/Shared/APIArray.h:41
> +    static inline const T *getObject(const RefPtr<Object>& object) { return
static_cast<const T *>(object.get()); }

*s are on the wrong side.

> Source/WebKit2/Shared/APIArray.h:44
> +    static inline bool isType(const RefPtr<Object> &object) { return
object->type() == T::APIType; }

& on the wrong side.

> Source/WebKit2/Shared/FilterIterator.h:43
> +private:
> +    const Predicate m_pred;
> +    const Cast m_cast;
> +    Iterator m_iter;
> +    Iterator m_end;
> +

This should go at the bottom, under the public part.

> Source/WebKit2/Shared/IteratorPair.h:36
> +    Iterator end() { return m_end; }
> +private:

Please put a newline between these two.