[webkit-reviews] review granted: [Bug 125119] Merging some more iOS WebKit2 stuff : [Attachment 218232] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 2 16:31:33 PST 2013


Tim Horton <thorton at apple.com> has granted Enrica Casucci <enrica at apple.com>'s
request for review:
Bug 125119: Merging some more iOS WebKit2 stuff
https://bugs.webkit.org/show_bug.cgi?id=125119

Attachment 218232: patch
https://bugs.webkit.org/attachment.cgi?id=218232&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218232&action=review


> Source/WebKit2/Shared/NativeWebTouchEvent.h:33
> +#ifdef __OBJC__

should this use OBJC_CLASS instead of all this madness?

it should be separated from the #if PLATFORM(EFL) section below.

> Source/WebKit2/Shared/mac/RemoteLayerTreePropertyApplier.mm:30
> +#import <QuartzCore/CALayer.h>

I think we usually include the whole framework, no? QuartzCore/QuartzCore.h?


More information about the webkit-reviews mailing list