[webkit-reviews] review granted: [Bug 124982] Nix Upstream: Updating Platform files : [Attachment 218014] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 124982: Nix Upstream: Updating Platform files
https://bugs.webkit.org/show_bug.cgi?id=124982

Attachment 218014: Patch
https://bugs.webkit.org/attachment.cgi?id=218014&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218014&action=review


This is all Nix "Platform" layer. LGTM.

> Source/Platform/nix/public/MediaStream.h:67
> +    // Caller must delete the returned MediaStreamSource*

Probably a good idea to enforce this by returning a vector of smart pointers.