[webkit-reviews] review denied: [Bug 124653] [texmap] Borders on rotating images are hidden/wrongly rendered with edge distance antialiasing : [Attachment 218159] Patch

[bugzilla-daemon at webkit.org]

Noam Rosenthal <noam at webkit.org> has denied José Dapena Paz
<jdapena at igalia.com>'s request for review:
Bug 124653: [texmap] Borders on rotating images are hidden/wrongly rendered
with edge distance antialiasing
https://bugs.webkit.org/show_bug.cgi?id=124653

Attachment 218159: Patch
https://bugs.webkit.org/attachment.cgi?id=218159&action=review

------- Additional Comments from Noam Rosenthal <noam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=218159&action=review


Nice, see comments

> Source/WebCore/platform/graphics/texmap/TextureMapperShaderProgram.cpp:328
> +	       vec4 clampedPosition = clamp(vec4(v_texCoord, 0., 1.), 0., 1.);
> +	       vec2 texCoord = (u_textureSpaceMatrix * clampedPosition).xy;

It's not a good idea to do this for every pixel. We should only do this when
there's an actual texture.
You should figure that into the other "optional" functions.