[webkit-reviews] review granted: [Bug 124613] Web Inspector: Push Remote Inspector debugging connection management into JavaScriptCore : [Attachment 217594] [PATCH] Part 2 - Make JSContext and WebCore::Page remote debuggables
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Mon Dec 2 12:36:13 PST 2013
Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 124613: Web Inspector: Push Remote Inspector debugging connection
management into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=124613
Attachment 217594: [PATCH] Part 2 - Make JSContext and WebCore::Page remote
debuggables
https://bugs.webkit.org/attachment.cgi?id=217594&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217594&action=review
> Source/JavaScriptCore/API/JSContextRef.cpp:234
> + }
> + ExecState* exec = toJS(ctx);
I'd put a newline in-between these lines.
> Source/JavaScriptCore/API/JSContextRef.cpp:246
> + }
> + ExecState* exec = toJS(ctx);
Ditto.
> Source/JavaScriptCore/API/JSContextRef.cpp:258
> + }
> + ExecState* exec = toJS(ctx);
Ditto.
More information about the webkit-reviews
mailing list