[webkit-reviews] review granted: [Bug 124874] Remote Layer Tree: Support cloning layers : [Attachment 217852] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 124874: Remote Layer Tree: Support cloning layers
https://bugs.webkit.org/show_bug.cgi?id=124874

Attachment 217852: patch
https://bugs.webkit.org/attachment.cgi?id=217852&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=217852&action=review


Does the right cleanup happen when a mask layer is removed?

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:102
> +   
clone->m_properties.notePropertiesChanged(static_cast<RemoteLayerTreeTransactio
n::LayerChange>(m_properties.everChangedProperties &
~RemoteLayerTreeTransaction::BackingStoreChanged));

Ugly cast :(

> Source/WebKit2/WebProcess/WebPage/mac/PlatformCALayerRemote.cpp:276
> +    m_maskLayer = toPlatformCALayerRemote(layer);

Can we call the field m_maskLayerID please? (Same with other LayerID fields).