[webkit-reviews] review canceled: [Bug 124533] Ability to iterate over API::Array : [Attachment 217968] refactor per Anders' review

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 2 09:32:07 PST 2013


Martin Hock <mhock at apple.com> has canceled Martin Hock <mhock at apple.com>'s
request for review:
Bug 124533: Ability to iterate over API::Array
https://bugs.webkit.org/show_bug.cgi?id=124533

Attachment 217968: refactor per Anders' review
https://bugs.webkit.org/attachment.cgi?id=217968&action=review

------- Additional Comments from Martin Hock <mhock at apple.com>
Thanks for the reference, Brady.  It seems like as a general rule of thumb, one
should always std::move constructor arguments passed by value into an
initializer list (assuming said arguments are not used elsewhere in the
constructor).  This avoids an extra copy (does the compiler usually optimize
away this kind of copy?)


More information about the webkit-reviews mailing list