[webkit-reviews] review granted: [Bug 125075] [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp macros : [Attachment 218164] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Dec 2 08:54:39 PST 2013


Michael Saboff <msaboff at apple.com> has granted Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 125075: [JSC] Get rid of some unused parameters in LLIntSlowPaths.cpp
macros
https://bugs.webkit.org/show_bug.cgi?id=125075

Attachment 218164: Patch
https://bugs.webkit.org/attachment.cgi?id=218164&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=218164&action=review


> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:145
> +#define LLINT_CALL_THROW(exec, exceptionToThrow) do {	       \

Please fix the whitespace so the '\' lines up with the subsequent lines.

> Source/JavaScriptCore/llint/LLIntSlowPaths.cpp:157
> +#define LLINT_CALL_RETURN(exec, callTarget) do {		       \

Same whitespace issue here.


More information about the webkit-reviews mailing list