[webkit-reviews] review requested: [Bug 124945] [MIPS] Small stack frame causes regressions. : [Attachment 218110] fixed patch.

[bugzilla-daemon at webkit.org]

Balazs Kilvady <kilvadyb at homejinni.com> has asked  for review:
Bug 124945: [MIPS] Small stack frame causes regressions.
https://bugs.webkit.org/show_bug.cgi?id=124945

Attachment 218110: fixed patch.
https://bugs.webkit.org/attachment.cgi?id=218110&action=review

------- Additional Comments from Balazs Kilvady <kilvadyb at homejinni.com>
I found that for 8 byte alignment reasons the 20 + x * 8 formula is reliable
for extraStackSpace and in tests the lowest best value is 36 (It sees we have
to add space for the four parameter registers on the stack also even if they
aren't used). In mozilla tests there are still 13 regressions but they are
caused by invalid register gp values. I think the fix of the gp problem should
go to an other bug report/patch.