[webkit-reviews] review granted: [Bug 52103] Video with object-fit: cover can spill outside the box : [Attachment 210175] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 52103: Video with object-fit: cover can spill outside the box
https://bugs.webkit.org/show_bug.cgi?id=52103

Attachment 210175: Patch
https://bugs.webkit.org/attachment.cgi?id=210175&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210175&action=review


> Source/WebCore/platform/graphics/ca/GraphicsLayerCA.cpp:1797
> +    bool needContentsClippingLayer =
!m_contentsClippingRect.contains(m_contentsRect);
> +    bool gainedOrLostClippingLayer = false;
> +    if (needContentsClippingLayer) {

You don't need needContentsClippingLayer.

> LayoutTests/compositing/video/video-object-fit.html:52
> +	       }, 1500);

1.5s :(