[webkit-reviews] review granted: [Bug 120448] [Windows] Video inside a web page always falls back to non-hardware accelerated : [Attachment 210155] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Brent Fulgham
<bfulgham at webkit.org>'s request for review:
Bug 120448: [Windows] Video inside a web page always falls back to non-hardware
accelerated
https://bugs.webkit.org/show_bug.cgi?id=120448

Attachment 210155: Patch
https://bugs.webkit.org/attachment.cgi?id=210155&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210155&action=review


Is this testable?

>> Source/WebCore/rendering/RenderLayerCompositor.cpp:2076
>> +	    return video->requiresImmediateCompositing() ||
(video->shouldDisplayVideo() && canAccelerateVideoRendering(video));
> 
> Parens would make this clearer: 
> 
> return (video->requiresImmediateCompositing() ||
(video->shouldDisplayVideo()) && canAccelerateVideoRendering(video));

WebKit style is to not add the outer parens.