[webkit-reviews] review granted: [Bug 120543] warning:=?UTF-8?Q?=20unused=20parameter=20=E2=80=98renderingMode?=' in ImageBufferCairo.cpp:94 : [Attachment 210146] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Aug 30 12:31:06 PDT 2013
Darin Adler <darin at apple.com> has granted Santosh Mahto
<santosh.ma at samsung.com>'s request for review:
Bug 120543: warning: unused parameter ‘renderingMode' in
ImageBufferCairo.cpp:94
https://bugs.webkit.org/show_bug.cgi?id=120543
Attachment 210146: Patch
https://bugs.webkit.org/attachment.cgi?id=210146&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210146&action=review
> Source/WebCore/platform/graphics/cairo/ImageBufferCairo.cpp:106
> + UNUSED_PARAM(renderingMode);
I think ASSERT_UNUSED might be better here, since we know what value we support
for rendering mode.
More information about the webkit-reviews
mailing list