[webkit-reviews] review granted: [Bug 120540] Use Element& in StyleResolveTree : [Attachment 210137] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120540: Use Element& in StyleResolveTree
https://bugs.webkit.org/show_bug.cgi?id=120540

Attachment 210137: patch
https://bugs.webkit.org/attachment.cgi?id=210137&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210137&action=review


r=me.

Obligatory whining about places where reasons for dereference safety is not
immediately clear:

> Source/WebCore/dom/ContainerNode.cpp:108
>  static inline void attachChild(Node* child)

This should take a Node&.

> Source/WebCore/dom/ContainerNode.cpp:116
>  static inline void detachChild(Node* child)

This should take a Node&.

> Source/WebCore/dom/Element.cpp:2303
> +    Style::resolveTree(*existingPseudoElement, needsStyleRecalc() ?
Style::Force : change);

This function should take a PseudoElement& instead of a PseudoElement*.

> Source/WebCore/style/StyleResolveTree.cpp:472
> +    PostAttachCallbackDisabler callbackDisabler(&current);

We should make this RAII object take a ContainerNode& instead.