[webkit-reviews] review granted: [Bug 120460] Web Inspector: exceptions triggered from console evaluation do not pause the debugger : [Attachment 210099] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Antoine Quint <graouts at apple.com>'s
request for review:
Bug 120460: Web Inspector: exceptions triggered from console evaluation do not
pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=120460

Attachment 210099: Patch
https://bugs.webkit.org/attachment.cgi?id=210099&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210099&action=review


> Source/WebInspectorUI/UserInterface/DebuggerManager.js:347
> +	       // Exclude the case where the call frame is in the inspector
code.
> +	       if (!sourceCodeLocation ||
sourceCodeLocation._sourceCode._url.indexOf("__WebInspector") === 0)
>		   continue;

Is there a more reliable way of doing this check? It seems annoying that this
could be fooled by a strange URL in the target code.

> Source/WebInspectorUI/UserInterface/JavaScriptLogViewController.js:235
> +	   text = "//@ sourceURL=__WebInspectorConsole__\n" + text;

If the point of this is to add something the other code can find, then I
suggest adding a brief “why we are doing this” comment here so someone won’t
just remove this later.