[webkit-reviews] review granted: [Bug 120496] Node::document() should return a reference. : [Attachment 210105] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Aug 30 07:18:18 PDT 2013


Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 120496: Node::document() should return a reference.
https://bugs.webkit.org/show_bug.cgi?id=120496

Attachment 210105: Patch
https://bugs.webkit.org/attachment.cgi?id=210105&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=210105&action=review


> Source/WebCore/html/HTMLMediaElement.cpp:3820
>  #if PLATFORM(WIN) && USE(AVFOUNDATION)
>  GraphicsDeviceAdapter*
HTMLMediaElement::mediaPlayerGraphicsDeviceAdapter(const MediaPlayer*) const
>  {
> -    if (!document() || !document()->page())
> +    if (!document() || !document().page())

That is not going to compile.


More information about the webkit-reviews mailing list