[webkit-reviews] review granted: [Bug 120501] Avoid Node references from AXObjectCache from leaking : [Attachment 210051] Fixes the bug

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 29 17:14:24 PDT 2013


Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 120501: Avoid Node references from AXObjectCache from leaking
https://bugs.webkit.org/show_bug.cgi?id=120501

Attachment 210051: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=210051&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
This seems OK, but I’m really surprised that attached() is the right check to
make here. I guess the option elements don’t themselves have renderers? In most
cases like this I think we’d check renderer() to see if it’s non-zero.


More information about the webkit-reviews mailing list