[webkit-reviews] review denied: [Bug 120318] AX: Crash when VoiceOver reference a TextMarker from an iframe that has been removed : [Attachment 210021] patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 29 13:22:16 PDT 2013
Darin Adler <darin at apple.com> has denied chris fleizach <cfleizach at apple.com>'s
request for review:
Bug 120318: AX: Crash when VoiceOver reference a TextMarker from an iframe that
has been removed
https://bugs.webkit.org/show_bug.cgi?id=120318
Attachment 210021: patch
https://bugs.webkit.org/attachment.cgi?id=210021&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210021&action=review
> Source/WebCore/accessibility/AXObjectCache.cpp:947
> +void AXObjectCache::clearTextMarkerNodesInUse(Document* doc)
Can we call this “document” instead of “doc” please?
> Source/WebCore/accessibility/AXObjectCache.cpp:958
> + break;
It looks like this will stop after finding one node.
More information about the webkit-reviews
mailing list