[webkit-reviews] review requested: [Bug 103771] [GStreamer] support in-band text tracks : [Attachment 210019] Split generic and WebVTT tracks, move WebVTTParser to InbandWebVTTTextTrack, move tests into .js files, add more expected.txt files, skip duplicate cues instead of deleting when we seek, and simplify language and label callbacks.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 29 13:02:18 PDT 2013


Brendan Long <b.long at cablelabs.com> has asked  for review:
Bug 103771: [GStreamer] support in-band text tracks
https://bugs.webkit.org/show_bug.cgi?id=103771

Attachment 210019: Split generic and WebVTT tracks, move WebVTTParser to
InbandWebVTTTextTrack, move tests into .js files, add more expected.txt files,
skip duplicate cues instead of deleting when we seek, and simplify language and
label callbacks.
https://bugs.webkit.org/attachment.cgi?id=210019&action=review

------- Additional Comments from Brendan Long <b.long at cablelabs.com>
Here another patch, which I think incorporates all of the changes Eric
suggested. I also figured out why the tests were failing for me (I needed to
add --wrapper=gst-git), so now all of the tests I added usually pass for
QtWebKit (although some of them are pretty flakey).


More information about the webkit-reviews mailing list