[webkit-reviews] review granted: [Bug 120480] Fix slider thumb event handling to use local, not absolute coordinates : [Attachment 210004] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 120480: Fix slider thumb event handling to use local, not absolute
coordinates
https://bugs.webkit.org/show_bug.cgi?id=120480

Attachment 210004: Patch
https://bugs.webkit.org/attachment.cgi?id=210004&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=210004&action=review


> Source/WebCore/ChangeLog:16
> +	   No behavior change.

Is there any test coverage for this?

> Source/WebCore/html/shadow/SliderThumbElement.cpp:271
> +    RenderBox* inputRenderer = toRenderBox(input->renderer());
> +    RenderBox* trackRenderer = trackElement->renderBox();

In modern code we like to use references for things that can’t be null. I would
use references for these two local variables.