[webkit-reviews] review denied: [Bug 120293] setAttributeNode() does not set the new value to an existing attribute if specified attribute is in a different case. : [Attachment 209968] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Aug 29 11:52:51 PDT 2013
Darin Adler <darin at apple.com> has denied Arpita Bahuguna
<arpitabahuguna at gmail.com>'s request for review:
Bug 120293: setAttributeNode() does not set the new value to an existing
attribute if specified attribute is in a different case.
https://bugs.webkit.org/show_bug.cgi?id=120293
Attachment 209968: Patch
https://bugs.webkit.org/attachment.cgi?id=209968&action=review
------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209968&action=review
> Source/WebCore/dom/Element.cpp:973
> + const QualifiedName& attributeName = (!inSynchronizationOfLazyAttribute
&& valueChanged) ? attributeAt(index).name() : name;
Needs to be ||, not &&.
More information about the webkit-reviews
mailing list