[webkit-reviews] review denied: [Bug 120460] Web Inspector: exceptions triggered from console evaluation do not pause the debugger : [Attachment 209979] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has denied Antoine Quint
<graouts at apple.com>'s request for review:
Bug 120460: Web Inspector: exceptions triggered from console evaluation do not
pause the debugger
https://bugs.webkit.org/show_bug.cgi?id=120460

Attachment 209979: Patch
https://bugs.webkit.org/attachment.cgi?id=209979&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209979&action=review


> Source/WebInspectorUI/UserInterface/DebuggerManager.js:346
> +	       if (!sourceCodeLocation || !sourceCodeLocation._sourceCode._url)


This is not correct. A page script can not have a URL if it is an eval() and
those still should be shown as anon scripts. We could still check for Inspector
scripts by adding a "// #sourceURL=__WebInspectorConsole__" to the user typed
strings to evaluate in InjectedScriptSource.js in WebCore or maybe even from
the front-end. Then look for that URL and block it.

> Source/WebInspectorUI/UserInterface/DebuggerSidebarPanel.js:340
> +	   // It is useful to turn off the step out button when there is no
call frame to go through
> +	   // since there might be call frames in the backend that we elected
to remove in the frontend.

Where are call frames removed?