[webkit-reviews] review granted: [Bug 120461] Move element renderer creation out of NodeRenderingContext : [Attachment 209965] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Aug 29 04:56:20 PDT 2013


Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 120461: Move element renderer creation out of NodeRenderingContext
https://bugs.webkit.org/show_bug.cgi?id=120461

Attachment 209965: patch
https://bugs.webkit.org/attachment.cgi?id=209965&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209965&action=review


r=me, nice!

> Source/WebCore/style/StyleResolveTree.cpp:137
> +    if (!element.document()->shouldCreateRenderers())
> +	   return false;

We should hoist this check up to the Document level so we don't have to run it
for every Element.


More information about the webkit-reviews mailing list