[webkit-reviews] review denied: [Bug 120389] JSArray::shiftCountWithArrayStorage doesn't change indexBias when shifting the last element in m_vector : [Attachment 209901] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Aug 28 17:34:54 PDT 2013


Mark Hahnenberg <mhahnenberg at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 120389: JSArray::shiftCountWithArrayStorage doesn't change indexBias when
shifting the last element in m_vector
https://bugs.webkit.org/show_bug.cgi?id=120389

Attachment 209901: Patch
https://bugs.webkit.org/attachment.cgi?id=209901&action=review

------- Additional Comments from Mark Hahnenberg <mhahnenberg at apple.com>
This patch is wrong. It breaks Facebook.


More information about the webkit-reviews mailing list