[webkit-reviews] review granted: [Bug 120436] Fix compositing layers in columns : [Attachment 209920] Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 120436: Fix compositing layers in columns
https://bugs.webkit.org/show_bug.cgi?id=120436

Attachment 209920: Patch
https://bugs.webkit.org/attachment.cgi?id=209920&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=209920&action=review


r=me

> Source/WebCore/rendering/RenderLayer.h:605
> +    enum ColumnOffsetAdjustment { DontAdjustForColumns, AdjustForColumns };
> +    void convertToPixelSnappedLayerCoords(const RenderLayer* ancestorLayer,
IntPoint& location, ColumnOffsetAdjustment adjustForColumns =
DontAdjustForColumns) const;
> +    void convertToPixelSnappedLayerCoords(const RenderLayer* ancestorLayer,
IntRect&, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns)
const;
> +    void convertToLayerCoords(const RenderLayer* ancestorLayer,
LayoutPoint&, ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns)
const;
> +    void convertToLayerCoords(const RenderLayer* ancestorLayer, LayoutRect&,
ColumnOffsetAdjustment adjustForColumns = DontAdjustForColumns) const;

I think above these functions would be a good place for a FIXME describing that
this is just a hack to get compositing layers to show up in a single column,
and that eventually we want them to work when split across columns.