[webkit-reviews] review granted: [Bug 19121] Namespace prefix is blindly followed when serializing : [Attachment 209919] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Rob Buis <rwlbuis at gmail.com>'s
request for review:
Bug 19121: Namespace prefix is blindly followed when serializing
https://bugs.webkit.org/show_bug.cgi?id=19121

Attachment 209919: Patch
https://bugs.webkit.org/attachment.cgi?id=209919&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=209919&action=review


>>> Source/WebCore/editing/MarkupAccumulator.cpp:512
>>> +			 ; // declare prefix using appendNamespace
>> 
>> Line contains only semicolon. If this should be an empty statement, use { }
instead.  [whitespace/semicolon] [5]
> 
> What happened here?

It seems like this case is hit when prefixIsAlreadyMappedToOtherNS is true, the
prefix is present, and hasn't appeared elsewhere yet?
Perhaps we can tweak the condition (and the name) of
prefixIsAlreadyMappedToOtherNS so that we don't have to check it here again.